Skip to content

Address Issue #74 - [DOC] add typings to functions #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-linnane-lrn merged 5 commits into from
Aug 30, 2024
Merged

Address Issue #74 - [DOC] add typings to functions #81

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da9afaa
[DOC] add typings - replace iterritems - add unit tests
michael-linnane-lrn Aug 16, 2024
3e18456
[CLEANUP] remove whitespace and add None default value back
michael-linnane-lrn Aug 16, 2024
cdc5d11
[REFACTOR] change assertRaises to assertRaisesRegex
michael-linnane-lrn Aug 16, 2024
6bbdb98
[CLEANUP] revert version change and changelog release date
michael-linnane-lrn Aug 20, 2024
6cfe64a
[DOC] update changelog and version to avoid pypi conflict
michael-linnane-lrn Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[REFACTOR] change assertRaises to assertRaisesRegex
  • Loading branch information
@michael-linnane-lrn
michael-linnane-lrn committed Aug 29, 2024
commit cdc5d11a82e3f39398261eda609b62f431f17107
12 changes: 3 additions & 9 deletions tests/unit/test_dataapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,10 @@ def test_results_iter_error_status(self):
for dummy in self.dummy_responses:
responses.add(responses.POST, self.endpoint, json={}, status=500)
client = DataApi()
with self.assertRaises(DataApiException) as cm:
with self.assertRaisesRegex(DataApiException, "server returned HTTP status 500"):
list(client.results_iter(self.endpoint, self.security, self.consumer_secret,
self.request, self.action))

self.assertEqual("server returned HTTP status 500", str(cm.exception))

@responses.activate
def test_results_iter_no_meta_status(self):
"""Verify that a DataApiException is raised when 'meta' 'status' is None"""
Expand All @@ -109,20 +107,16 @@ def test_results_iter_no_meta_status(self):
for dummy in self.dummy_responses:
responses.add(responses.POST, self.endpoint, json=dummy)
client = DataApi()
with self.assertRaises(DataApiException) as cm:
with self.assertRaisesRegex(DataApiException, "server returned unsuccessful status:"):
list(client.results_iter(self.endpoint, self.security, self.consumer_secret,
self.request, self.action))

self.assertEqual("server returned unsuccessful status:", str(cm.exception))

@responses.activate
def test_results_iter_invalid_response_data(self):
"""Verify that a DataApiException is raised response data isn't valid JSON"""
for dummy in self.dummy_responses:
responses.add(responses.POST, self.endpoint, json=None)
client = DataApi()
with self.assertRaises(DataApiException) as cm:
with self.assertRaisesRegex(DataApiException, "server returned invalid json: "):
list(client.results_iter(self.endpoint, self.security, self.consumer_secret,
self.request, self.action))

self.assertEqual("server returned invalid json: ", str(cm.exception))