-
Notifications
You must be signed in to change notification settings - Fork 14
Check Package Version Matches Release Tag On Deployment #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Package Version Matches Release Tag On Deployment #83
Conversation
|
💭 thought (non-blocking): We could potentially use autogenerated release notes as the single source of truth for the Changelog instead of 💭 thought (non-blocking): we could potentially remove |
|
Autogenerating |
@shtrom I'll investigate the consequences of removing |
842485a to
faae20b
Compare
4b04394 to
95b404a
Compare
Overview
Proposal to add a Versio Check step to the release action to ensure the release git tag version matches
learnosity/_version.py.This works well with the new workflow added by @walsh-conor.
Context
This came out of my initial experience with #80 where after creating a pre-release, it has overwritten v0.3.8 in
PyPI, as when creating the release,_version.pywas still used.https://github.com/Learnosity/learnosity-sdk-python/releases/tag/v0.3.13-pre
This has been added to the documentation for contributing that a version bump is required for release.
Info on what
github.ref_nameis and why it matches forreleasewhere we create a new tag.https://github.com/orgs/community/discussions/26686
Testing
This small step was manually tested in a fork of the project here:
https://github.com/ferdia-sopermaccafraidh-lrn/learnosity-sdk-python
Successful Run where the tag matches:

https://github.com/ferdia-sopermaccafraidh-lrn/learnosity-sdk-python/actions/runs/10992052191/job/30515674757
Failed Run where the reference didn't match (on a push so the ref_name was

master).https://github.com/ferdia-sopermaccafraidh-lrn/learnosity-sdk-python/actions/runs/10992018237/job/30515573917
Changes
Checklist