[CHANGE] Implements code review changes - AIL-44

.github/workflows/ci.yml

@@ -34,8 +34,8 @@ jobs:
         with:
           python-version: '3.9'
 
-      - name: Install Mypy Dependencies
-        run: pip install mypy
+      - name: Install Test Dependencies
+        run: pip install .[test]
 
       - name: Type Checking with Mypy
         run: mypy

learnosity_sdk/request/init.py

@@ -40,7 +40,8 @@ def __init__(
         self.security = security.copy()
         self.secret = secret
         self.request = request
-        if request is not None and hasattr(request, 'copy'):
+        # TODO: Fix improper handling when request is a string
+        if isinstance(request, dict):
             self.request = request.copy()
         self.action = action
 

setup.py

@@ -25,6 +25,7 @@
     'pytest-subtests',
     'responses >=0.8.1',
     'types-requests',
+    'types-Jinja2',
     'mypy',
 ]
 

tests/unit/test_uuid.py

@@ -1,4 +1,3 @@
-from typing import cast
 import unittest
 import re
 from learnosity_sdk.utils import Uuid
@@ -13,6 +12,5 @@ def test_generate(self) -> None:
         prog = re.compile('[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}')
         result = prog.match(generated)
 
-        assert result != None
-        result = cast(re.Match[str], result)
+        assert result is not None
         assert result.group() == generated