Issue/2 hello react #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicmator
reviewed
Nov 1, 2016
01 HelloReact/readme.md
Outdated
| from js to jsx and replace the content). | ||
|
|
||
| ```javascript | ||
| iimport React from 'react'; |
Collaborator
There was a problem hiding this comment.
import React from 'react';
01 HelloReact/webpack.config.js
Outdated
| module: { | ||
| loaders: [ | ||
| { | ||
| test: /\.jsx$/, |
Collaborator
There was a problem hiding this comment.
Fix that to put code inline better.
Collaborator
There was a problem hiding this comment.
To explain better, "Code formatting (tabs)"
Contributor
Author
There was a problem hiding this comment.
Yes, I've configured atom now to display all whitespace characters
Member
|
@hithwen There are open points in this PR, do you have time to work on them or do you prefer another team mate to tackle on them? Thanks |
Contributor
Author
|
Comments addressed |
Member
|
Good stuff, going to merge, please @vicmator or @rocioghermoso update kanban and issue status, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.