Conversation
- Create Dockerfile.ubuntu based on Ubuntu 24.04 with Go 1.26 from longsleep PPA - Update CI workflow to use matrix strategy for parallel builds - Configure matrix with Alpine (Dockerfile) and Ubuntu (Dockerfile.ubuntu) variants - Add tag suffixes for versioned tags: v1.0.0-ubuntu, develop-ubuntu - Set latest tags: latest for Alpine, ubuntu for Ubuntu variant
This comment has been minimized.
This comment has been minimized.
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
- Detect architecture dynamically using dpkg --print-architecture - Select appropriate yq binary (amd64 or arm64) based on system architecture - Remove unused GO_VERSION build argument - Ensures compatibility with multi-platform build matrix in workflow
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an Ubuntu-based Docker image variant for the portal-builder and implements a matrix build strategy to automate the creation of both image variants.
Key Changes:
New Ubuntu Docker Image: Added
Dockerfile.ubuntuwhich creates an Ubuntu 24.04-based build environment. This provides an alternative to the existing base image for users who require Ubuntu-specific dependencies or prefer Ubuntu as their base OS. The image includes Go 1.26, build tools, yq (YAML processor), xportal, and pre-cached Go modules for faster builds.Matrix Build Strategy: Modified the GitHub Actions workflow to use a build matrix that constructs both image variants in parallel:
Dockerfile) tagged aslatestDockerfile.ubuntu) tagged asubuntuand with the-ubuntusuffix on all other tagsEnhanced Tagging: Updated the Docker metadata configuration to dynamically apply the appropriate tag suffix (
-ubuntu) to the Ubuntu variant while maintaining the standard tagging scheme for the base image.The changes enable users to pull either
ghcr.io/lumeweb/portal-builder:latest(standard) orghcr.io/lumeweb/portal-builder:ubuntu(Ubuntu-based) depending on their build requirements, with both images being automatically built and published on every release.