fix: add GOPROXY=direct to xportal build commands#5
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
build-portal.shscript to ensurexportal buildcommands fetch Go modules directly from source rather than through the Go module proxy.Key Changes:
Added
GOPROXY=directenvironment variable: Introduced arun_xportal()helper function that setsGOPROXY=directwhen executingxportal build. This forces Go to bypass the module proxy cache and fetch dependencies directly from their source repositories (e.g., GitHub), ensuring the latest versions are used and avoiding potential stale cache issues.Refactored build logic: Consolidated the previously duplicated
xportal buildinvocation patterns (handling optional output directories and plugin arguments) into a single call through therun_xportalhelper. This eliminates repetitive environment variable exports and reduces code duplication while maintaining the same functionality for building with or without plugins and custom output paths.Functional Impact: