gcc: fix get_completion_scheduler for -Og#1145
Merged
ericniebler merged 2 commits intoNVIDIA:mainfrom Nov 19, 2023
Merged
Conversation
The get_completion_schedule failed to link with -Og. There doesn't appear to be a direct way to detect this with pre-processor flags. Therefore, switch the detection so that only size-optimization results in the template type (__OPTIMIZE_SIZE__ instead of __OPTIMIZE__). Fixes: d5d5cab Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
williamspatrick
force-pushed
the
main
branch
from
02ca54e to
6b027bc
Compare
Collaborator
|
the summary for this pr is inaccurate, since it's only the one fix. /ok to test |
Contributor
Author
|
I’ll fix that. I did something funny with the rebase against the content that merged yesterday and then |
Collaborator
|
/ok to test |
Collaborator
|
/ok to test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.