let_value, _error, & _stopped: Use After Move On Exception From Connect#1711
Merged
ericniebler merged 1 commit intoNVIDIA:mainfrom Dec 15, 2025
Merged
Conversation
When a completion signal is sent on the appropriate completion channel (i.e. set_value, set_error, or set_stopped) let_value, let_error, and let_stopped (respectively): 1. Store the values associated with the signal, if any, 2. Invoke their associated invocable with those stored values, and then 3. Connect the sender returned by that invocation Prior to this commit the implementation of the operations enumerated above moved the final receiver into the connect operation in step 3 (more precisely those implementations moved the final receiver into a wrapper receiver which was in turn moved into that connect operation). This meant that if the connect operation: 1. Decay-copied the receiver (thereby moving from it), and then 2. Threw an exception The resulting error completion signal would be sent to a receiver which had been moved from. Reproduced in a unit test and fixed.
Collaborator
|
/ok to test 43feda9 |
Collaborator
|
thanks, robert! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a completion signal is sent on the appropriate completion channel (i.e. set_value, set_error, or set_stopped) let_value, let_error, and let_stopped (respectively):
Prior to this commit the implementation of the operations enumerated above moved the final receiver into the connect operation in step 3 (more precisely those implementations moved the final receiver into a wrapper receiver which was in turn moved into that connect operation). This meant that if the connect operation:
The resulting error completion signal would be sent to a receiver which had been moved from.
Reproduced in a unit test and fixed.