stdexec::stoppable_token & ::stop_token_for_t: Support std::stop_token#1726
Merged
ericniebler merged 4 commits intoNVIDIA:mainfrom Jan 2, 2026
Merged
stdexec::stoppable_token & ::stop_token_for_t: Support std::stop_token#1726ericniebler merged 4 commits intoNVIDIA:mainfrom
ericniebler merged 4 commits intoNVIDIA:mainfrom
Conversation
Both the stdexec::stoppable_token concept and the stdexec:: stop_token_for_t template type alias depend on the stop token type having a unary member template named callback_type. While P2300 added the aforementioned member template to std::stop_token that means that before C++26 the aforementioned utilities don't work therewith. Special cased: - stdexec::stoppable_token to allow std::stop_token without checking for the above-mentioned member template, and - stdexec::stop_token_t to resolve to std::stop_callback<Callback> when its first template argument is std::stop_token
RobertLeahy
force-pushed
the
stop_token_20251230
branch
from
0b8ebea to
89f1e58
Compare
ericniebler
approved these changes
Dec 31, 2025
Collaborator
|
/ok to test 89f1e58 |
Collaborator
|
/ok to test 87f51c3 |
Collaborator
|
/ok to test 835c6a4 |
Collaborator
|
/ok to test a1b120c |
williamspatrick
pushed a commit
to williamspatrick/stdexec
that referenced
this pull request
Feb 17, 2026
NVIDIA#1726) Both the stdexec::stoppable_token concept and the stdexec:: stop_token_for_t template type alias depend on the stop token type having a unary member template named callback_type. While P2300 added the aforementioned member template to std::stop_token that means that before C++26 the aforementioned utilities don't work therewith. Special cased: - stdexec::stoppable_token to allow std::stop_token without checking for the above-mentioned member template, and - stdexec::stop_token_t to resolve to std::stop_callback<Callback> when its first template argument is std::stop_token --------- Co-authored-by: Eric Niebler <eniebler@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the stdexec::stoppable_token concept and the stdexec::stop_token_for_t template type alias depend on the stop token type having a unary member template named callback_type. While P2300 added the aforementioned member template to std::stop_token that means that before C++26 the aforementioned utilities don't work therewith.
Special cased: