change specification of sender_traits and connect to make awaitables senders#178
Merged
ericniebler merged 5 commits intomainfrom Sep 29, 2021
Merged
change specification of sender_traits and connect to make awaitables senders#178ericniebler merged 5 commits intomainfrom
ericniebler merged 5 commits intomainfrom
Conversation
ericniebler
force-pushed
the
awaitables-are-senders
branch
from
52a438c to
da8d5c8
Compare
griwes
approved these changes
Aug 25, 2021
Collaborator
griwes
left a comment
griwes
left a comment
There was a problem hiding this comment.
This looks reasonable to me, though we should definitely have Lewis read through this as well.
lewissbaker
reviewed
Aug 26, 2021
| template<template<class...> class Tuple, template<class...> class Variant> | ||
| using value_types = Variant<Tuple<>>; | ||
|
|
||
| template<template<class...> class Variant> |
Contributor
There was a problem hiding this comment.
Can we make this the empty variant if the co_await expression is nothrow?
I know that the coroutine allocation might throw but that would throw out of connect, not through set_error.
Collaborator
Author
There was a problem hiding this comment.
That would be, if __get_awaiter is nothrow and all of the 3 awaiter members are nothrow? I'm not sure how to test if await_suspend throws without knowing the promise type. I don't think it's computable in library code.
lewissbaker
reviewed
Aug 26, 2021
lewissbaker
reviewed
Aug 26, 2021
lewissbaker
reviewed
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #150