Move associate's opstate into the get_state function #1831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ispeters
force-pushed
the
move_associate_op_state
branch
2 times, most recently
from
51b0e1b to
c6e7a7c
Compare
This diff better aligns the implementation of `associate` with how it's worded in the spec; it moves the definition of the associate-sender's operation state type into the `get_state` function, making it a function-local class.
ispeters
force-pushed
the
move_associate_op_state
branch
from
c6e7a7c to
9d49e68
Compare
ispeters
commented
Feb 11, 2026
| : __assoc_(std::move(__parts.first)) { | ||
| if (__assoc_) { | ||
| ::new ((void*) std::addressof(__op_)) | ||
| __op_t(STDEXEC::connect(std::move(*__parts.second), std::move(__rcvr))); |
Contributor
Author
There was a problem hiding this comment.
The spec doesn't fully-qualify this call to connect; it's required in stdexec to avoid an ambiguity with (I think) a member connect that's in scope here. I'm wondering if basic-sender has the same ambiguity as __sexpr_defaults.
|
|
||
| void __run() noexcept { | ||
| if (__assoc_) { | ||
| STDEXEC::start(__op_); |
Contributor
Author
There was a problem hiding this comment.
This call to start has the same problem as the above call to connect.
Collaborator
|
tbh i don't really want local classes for anything, ever. their mangled names are horrible and make diagnostics harder to read. i only used them in P2300 to make the spec more terse. my hope is that library implementers would liberally apply the AS-IF rule and use different implementation strategies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff better aligns the implementation of
associatewith how it's worded in the spec; it moves the definition of the associate-sender's operation state type into theget_statefunction, making it a function-local class.