__completion_signatures_of_t requires that get_completion_signatures<S,E...>() is a constant expression#1899
Open
ericniebler wants to merge 2 commits intoNVIDIA:mainfrom
Open
Conversation
…es<S,E...>()` is a constant expression
d5216a9 to
4a2f36b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, the definition of the
__completion_signatures_of_talias is:the trouble with this is that if
get_completion_signaturesexits with a compile-time exception, that error is lost, and we end up aliasing the declared return type ofget_completion_signatures, akacompletion_signatures<>.a better definition looks like
where
__mtypeofis simply:this causes
__completion_signatures_of_tto SFINAE when the call toget_completion_signaturesis not a constant expression.