Merged
Conversation
Contributor
williamspatrick
commented
Oct 10, 2022
williamspatrick
commented
- __meta: add exception include
- p2300: fix with_awaitable_senders export
The header file stdexec/__detail/__meta.hpp is using std::terminate, which comes from <exception>. Add the necessary include. Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
stdexec::with_awaitable_senders was not properly exported into std::execution. It was forward declared as a struct, but that forward declaration was not fulfilled anywhere. Switch to a using like all the other std::execution aliases. Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.