Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Add rudimentary CMake support for Feta#1102

Merged
brycelelbach merged 1 commit intomasterfrom
feature/feta-cmake-support
May 7, 2020
Merged

Add rudimentary CMake support for Feta#1102
brycelelbach merged 1 commit intomasterfrom
feature/feta-cmake-support

Conversation

@brycelelbach
Copy link
Collaborator

@brycelelbach brycelelbach commented Apr 15, 2020

No description provided.

@brycelelbach brycelelbach force-pushed the feature/feta-cmake-support branch from 1f4da0d to a6b2bfb Compare April 15, 2020 19:15
dkolsen-pgi
dkolsen-pgi reviewed Apr 15, 2020
View reviewed changes
dkolsen-pgi
dkolsen-pgi reviewed Apr 15, 2020
View reviewed changes
dkolsen-pgi
dkolsen-pgi reviewed Apr 15, 2020
View reviewed changes
dkolsen-pgi
dkolsen-pgi reviewed Apr 15, 2020
View reviewed changes
@dkolsen-pgi
Copy link
Collaborator

dkolsen-pgi commented Apr 15, 2020

I don't know Cmake, so I can't do a meaningful review of most of the change. But I did spot what looks like several incorrect compiler arguments.

@brycelelbach brycelelbach force-pushed the feature/feta-cmake-support branch from a6b2bfb to bb3316b Compare April 15, 2020 22:40
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Apr 16, 2020

Can everyone please re-review, I've made some updates.

griwes
griwes suggested changes Apr 16, 2020
View reviewed changes
@griwes griwes requested a review from alliepiper April 16, 2020 01:00
@brycelelbach brycelelbach force-pushed the feature/feta-cmake-support branch from bb3316b to f66578d Compare April 16, 2020 01:15
griwes
griwes approved these changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. I'll do some sanity checks with my preexisting scripts to see if all's good.

griwes
griwes suggested changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on, my scripts no longer set the CUDA host compiler correctly (and I'm passing it via env variable CXX). Don't merge while I investigate.

griwes
griwes suggested changes Apr 16, 2020
View reviewed changes
@brycelelbach brycelelbach force-pushed the feature/feta-cmake-support branch from f66578d to 42e44a0 Compare April 16, 2020 02:33
alliepiper
alliepiper reviewed Apr 16, 2020
View reviewed changes
alliepiper
alliepiper reviewed Apr 16, 2020
View reviewed changes
@alliepiper
Copy link
Collaborator

alliepiper commented Apr 16, 2020

I really dislike the pattern of changing the compiler variables programmatically for the reasons mentioned inline. But since we already do that, I wouldn't hold this PR up over it, we can address that later in the eventual CMake refactor.

The other suggestion about the arch option is a "nice to know" low priority QOL change that can be skipped for now. I assume most of these hacks are temporary until we get proper CMake support for Feta, so if it works for feta and doesn't break existing usecases, I'm ok with merging.

@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Apr 17, 2020

I really dislike the pattern of changing the compiler variables programmatically for the reasons mentioned inline. But since we already do that, I wouldn't hold this PR up over it, we can address that later in the eventual CMake refactor.

Until CMake has first class support for Feta, we probably can't avoid this.

@brycelelbach brycelelbach added this to the 1.9.10 milestone Apr 30, 2020
@brycelelbach brycelelbach force-pushed the feature/feta-cmake-support branch from 42e44a0 to b7b0cb1 Compare May 5, 2020 23:36
@brycelelbach brycelelbach force-pushed the feature/feta-cmake-support branch from b7b0cb1 to 3689112 Compare May 6, 2020 01:22
brycelelbach
brycelelbach commented May 6, 2020
View reviewed changes
CMakeLists.txt Outdated
PRIVATE ${PROJECT_SOURCE_DIR}/testing
)

if ("Feta" STREQUAL "${CMAKE_CUDA_COMPILER_ID}")
Copy link
Collaborator Author

@brycelelbach brycelelbach May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to only take this branch if the device backend is CUDA.

@brycelelbach brycelelbach force-pushed the feature/feta-cmake-support branch 2 times, most recently from e5daaa4 to d359d02 Compare May 6, 2020 22:41
@brycelelbach
* Add rudimentary CMake support for Feta.
a2a85bf 
* Refactor RDC handling to not create separate explicit targets.
* Drive-by: Don't use the NVCC version of `normal_distribution_base` for
  Feta because it uses `erfcinv`, a non-standard function that Feta doesn't
  have.

Reviewed-by: Allison Vacanti <alliepiper16@gmail.com>
Reviewed-by: Michał 'Griwes' Dominiak <griwes@griwes.info>
Reviewed-by: David Olsen <dolsen@nvidia.com>
@brycelelbach brycelelbach force-pushed the feature/feta-cmake-support branch from d359d02 to a2a85bf Compare May 6, 2020 22:42
@brycelelbach brycelelbach merged commit 3a83c55 into master May 7, 2020
@brycelelbach brycelelbach deleted the feature/feta-cmake-support branch May 7, 2020 00:21
@brycelelbach brycelelbach restored the feature/feta-cmake-support branch May 16, 2020 06:57
@brycelelbach brycelelbach deleted the feature/feta-cmake-support branch May 16, 2020 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@alliepiper alliepiper alliepiper approved these changes

@griwes griwes griwes approved these changes

@dkolsen-pgi dkolsen-pgi dkolsen-pgi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9.10

Development

Successfully merging this pull request may close these issues.

4 participants

@brycelelbach @dkolsen-pgi @alliepiper @griwes