Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Create CODE_OF_CONDUCT.md #1138

Merged
alliepiper merged 1 commit into from
Jun 23, 2020
Merged

Create CODE_OF_CONDUCT.md #1138

alliepiper merged 1 commit into from
Jun 23, 2020

Conversation

@codereport
Copy link
Collaborator

@codereport codereport commented May 11, 2020

Resolves #1133

@codereport codereport requested a review from brycelelbach May 11, 2020 20:18
@codereport codereport self-assigned this May 11, 2020
@codereport
Copy link
Collaborator Author

codereport commented May 11, 2020

If / once this is approved, I will duplicate the PR for cub.

@brycelelbach
Copy link
Collaborator

brycelelbach commented May 12, 2020

All reviewers please sign-off.

dkolsen-pgi
dkolsen-pgi suggested changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@dkolsen-pgi dkolsen-pgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual code of conduct parts are fine. I have no objections to those.

But there are two references to RAPIDS that I assume should be changed to Thrust (or something else not RAPIDS). The Overview section says that this the code of conduct for all RAPIDS projects. The Enforcement section lists a RAPIDS e-mail address.

griwes
griwes suggested changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the following references to RAPIDS; otherwise this looks good to go for me.

@brycelelbach
Copy link
Collaborator

brycelelbach commented May 12, 2020 via email •
edited
Loading

alliepiper
alliepiper suggested changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the rapids references are updated.

@alliepiper
Copy link
Collaborator

alliepiper commented May 12, 2020

I can land this later today with some other changes that are going in.

@alliepiper alliepiper self-requested a review May 12, 2020 16:12
alliepiper
alliepiper suggested changes May 12, 2020
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a typo last minute, and I wanted to make sure that all four of the email addresses were active before merging this.

@codereport codereport requested a review from alliepiper May 13, 2020 00:13
@codereport codereport mentioned this pull request May 13, 2020
Merged
@alliepiper alliepiper force-pushed the master branch 2 times, most recently from c6dd0d5 to eaf63fe Compare May 15, 2020 16:21
@alliepiper
Copy link
Collaborator

alliepiper commented May 15, 2020

This is ready to land (shelve 28408075) once I get a 👍 from @brycelelbach that the email accounts are active.

@brycelelbach brycelelbach mentioned this pull request May 20, 2020
Merged
@alliepiper alliepiper added only: docs Documentation changes only. Doesn't need code CI. blocked Cannot make progress. labels May 28, 2020
brycelelbach
brycelelbach reviewed Jun 3, 2020
View reviewed changes
@brycelelbach brycelelbach removed the blocked Cannot make progress. label Jun 4, 2020
@brycelelbach
Copy link
Collaborator

brycelelbach commented Jun 4, 2020

NVIDIA legal signed off. Please change the email to [email protected] and then this is approved for merge.

brycelelbach
brycelelbach approved these changes Jun 4, 2020
View reviewed changes
@brycelelbach
Copy link
Collaborator

brycelelbach commented Jun 22, 2020

@codereport can you rebase this? Looks like you have a conflict.

@alliepiper
Copy link
Collaborator

alliepiper commented Jun 22, 2020

@brycelelbach Are you good with merging this now?

I'll replace the merge commit with a rebase when I land this (I don't think perforce integration will like the merge commit).

@brycelelbach
Copy link
Collaborator

brycelelbach commented Jun 23, 2020

Yes. Rebase commit would be best.

@codereport @alliepiper
Create CODE_OF_CONDUCT.md
a962500 
Reviewed-by: Bryce Adelstein Lelbach aka wash <[email protected]>
Reviewed-by: David Olsen <[email protected]>
Reviewed-by: Michał 'Griwes' Dominiak <[email protected]>
Reviewed-by: Allison Vacanti <[email protected]>
@alliepiper alliepiper merged commit 2b17035 into NVIDIA:master Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jaredhoberock jaredhoberock Awaiting requested review from jaredhoberock

4 more reviewers

@alliepiper alliepiper alliepiper approved these changes

@brycelelbach brycelelbach brycelelbach approved these changes

@griwes griwes griwes approved these changes

@dkolsen-pgi dkolsen-pgi dkolsen-pgi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@codereport codereport

Labels

only: docs Documentation changes only. Doesn't need code CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CODE_OF_CONDUCT.md?

5 participants

@codereport @brycelelbach @alliepiper @griwes @dkolsen-pgi