This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Fix issues so all host/device combinations build and pass tests. #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
commented
May 18, 2020
Collaborator
Author
|
This fixes #1075. |
Collaborator
Author
|
CI: 28424174 |
brycelelbach
approved these changes
May 20, 2020
Collaborator
brycelelbach
left a comment
brycelelbach
left a comment
There was a problem hiding this comment.
Look into my comments, and then this looks good to go.
Collaborator
Author
|
I found some issues with the |
alliepiper
force-pushed
the
feature/fix_tbb_with_vs
branch
from
79a6cd5 to
4d4fae1
Compare
alliepiper
changed the title
Collaborator
Author
|
Rerunning CI in 28484502. |
alliepiper
added
testing: internal ci in progress
- Add more metadata to mock specializations for testing iterator in
testing/copy.cu.
- Add missing include to shuffle unit test.
- Specialize wrapped_function for void return types.
- MSVC is not a fan of the pattern `return static_cast<void>(expr);`.
- Replace deprecated `tbb/tbb_thread.h` with `<thread>`.
- Fix overcounting of initial value in tbb scans.
- Apparently reverse_join may be called before operator()
- Use `thrust::advance` instead of `+=` for generic iterators.
- Wrap the OMP flags in -Xcompiler for NVCC
- Extend ASSERT_STATIC_ASSERT skip for HOST=OMP, too
- Add missing header caught by tbb.cuda configs.
- Fix 'unsafe API' warnings in examples on MSVC: s/fopen/fstream/
alliepiper
force-pushed
the
feature/fix_tbb_with_vs
branch
from
4d4fae1 to
5fc37c1
Compare
alliepiper
added
testing: internal ci passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing/copy.cu.
return static_cast<void>(expr);.tbb/tbb_thread.hwith<thread>.thrust::advanceinstead of+=for generic iterators.