This repository was archived by the owner on Mar 21, 2024. It is now read-only.
gpuCI: Local docker builds and gpuCI GPU support #1317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for local docker builds in a gpuCI-like environment.
- Rename the existing `ci/cpu/build.bash` to `ci/common/build.bash`.
- Create two new scripts, `ci/{cpu,gpu}/build.bash`, that source
`ci/common/build.bash`.
- Fix uses of the wrong Bash variable name.
brycelelbach
force-pushed
the
feature/local-docker-builds
branch
from
d516d5c to
c9f60d1
Compare
- Run `ldconfig` as root in local containerized builds to workaround issues with nvidia-docker2 and Debian. - Add a "clean" option to local containzered builds. - Stop using the "c++" and "cu++" symlinks, because NVCC doesn't like being symlinked to (it breaks nvcc.profile). - Add script for determining parallelism, based on the one we used with DVS.
brycelelbach
force-pushed
the
feature/local-docker-builds
branch
from
82dade7 to
bca02bf
Compare
alliepiper
suggested changes
Oct 14, 2020
Collaborator
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
The multiconfig stuff needs to be fixed up for sure, the rest are just FYIs/suggestions.
I'm looking forward to trying this out!
`determine_build_parallelism.bash` for local builds.
raydouglass
reviewed
Oct 16, 2020
…hey didn't already exist.
- Make the build directory, not the repository root, the starting directory in containers. - Turn off C++17 mode for now until we have an easy way to say "use it if the compiler supports it" - see #1321. - Make invocation with a specific test target work as intended. - `ci/local/build.bash`: Don't print out build parallelism information if invoking in shell only mode.
alliepiper
approved these changes
Oct 20, 2020
| fi | ||
|
|
||
| if [ ! -z "${@}" ]; then | ||
| CTEST_FLAGS="${CTEST_FLAGS} -R ^${@}$" |
Collaborator
There was a problem hiding this comment.
Two things to be aware of:
- This only supports a single target.
- This won't work with configuration metatargets because of the trailing
$
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci/cpu/build.bashtoci/common/build.bash.ci/{cpu,gpu}/build.bash, that sourceci/common/build.bash.