This repository was archived by the owner on Mar 21, 2024. It is now read-only.
thrust::universal_vector, thrust::universal_ptr, and thrust::universal_allocator
#1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
run tests |
brycelelbach
force-pushed
the
feature/universal-vector-ptr-allocator
branch
from
20966ed to
14df646
Compare
Collaborator
Author
|
run tests |
Collaborator
Author
|
K now this PR changes all the backend |
brycelelbach
force-pushed
the
feature/universal-vector-ptr-allocator
branch
from
14df646 to
2441dcb
Compare
Collaborator
Author
|
run tests |
brycelelbach
force-pushed
the
feature/universal-vector-ptr-allocator
branch
3 times, most recently
from
47b9dd8 to
2d216c0
Compare
Collaborator
Author
|
run tests |
alliepiper
suggested changes
Nov 2, 2020
Collaborator
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
gpuCI build is failing.
brycelelbach
force-pushed
the
feature/universal-vector-ptr-allocator
branch
from
2d216c0 to
8433d30
Compare
Collaborator
Author
|
run tests |
alliepiper
reviewed
Nov 18, 2020
Collaborator
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
There's a lot of unrelated formatting changes that make the diff really noisy, but everything looks ok other than the comment about the changelog. I'll start running tests on this soon.
Collaborator
|
DVS CL: 29342412 |
alliepiper
added
testing: internal ci in progress
Collaborator
|
DVS is failing, lots of timeouts on DVS-SC, and libcu++ issues are causing failing prereqs for DVS-AUS. We'll try again later... |
- `thrust::universal_vector`. - `thrust::universal_ptr`. - `thrust::universal_allocator`. Change all backend fancy pointer and reference types to be aliases. Substantially refactor `thrust::reference`. Fix a bug that allowed `thrust::reference`s to const objects to be swapped: https://godbolt.org/z/r9G4nY Introduce a new `thrust::tagged_reference` type that breaks the circular template argument dependency between `thrust::pointer` and `thrust::reference`.
alliepiper
force-pushed
the
feature/universal-vector-ptr-allocator
branch
from
8433d30 to
b778e2a
Compare
Collaborator
|
Rebased on Rerunning DVS to see if issues are resolved, repro timeouts. DVS CL: 29371571 |
alliepiper
added
testing: internal ci passed
alliepiper
approved these changes
Dec 4, 2020
brycelelbach
added a commit
that referenced
this pull request
Dec 25, 2020
… from both hosts and devices" to fix git blame authorship. This reverts commit b778e2a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the underlying abstractions for unified memory a few releases ago, but typedefs of common Thrust abstractions that use unified memory are missing.
This causes user code to have to define these things themselves or spell them out, which is unnecessarily verbose. For example:
https://github.com/NVIDIA/libcudacxx/pull/31/files#diff-4eac15e63f9ee8faca1e62f47615b520927b5ab10f42043963c84c4d493750b8R25-R39