Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Add gpuCI GPU testing, automatic GPU detection, and support for more compilers#1350

Merged
brycelelbach merged 1 commit intomainfrom
feature/auto-detect-archs
Dec 24, 2020
Merged

Add gpuCI GPU testing, automatic GPU detection, and support for more compilers#1350
brycelelbach merged 1 commit intomainfrom
feature/auto-detect-archs

Conversation

@brycelelbach
Copy link
Collaborator

@brycelelbach brycelelbach commented Dec 4, 2020 •
edited
Loading

Add gpuCI GPU testing, automatic GPU detection, and support for more compilers:

  • CMake: Add support for detecting the compute archs of the GPUs in your system
    at configure time.
  • gpuCI: Add a GPU node configuration that builds and tests as little as possible.
  • gpuCI: Cleanup logic for different build and test configurations.
  • gpuCI: Fix an unfortunate typo in determine_build_parallelism.bash which
    led to the parallelism level not being set.
  • gpuCI: Add support for NVC++.
  • gpuCI: Update to CUDA 11.1 and Ubuntu 20.04.
  • gpuCI: Add NVC++ and ICC configurations to the CPU axis file.
  • gpuCI: Add a GPU axis file.
  • gpuCI: Increase the desired memory per build thread to 4GB.
  • gpuCI: Add a -j switch which controls build parallelism to ci/local/build.bash.

@brycelelbach brycelelbach added this to the 1.12.0 milestone Dec 4, 2020
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 5, 2020

ok to test

@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 5, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from b329543 to 2d4b69d Compare December 5, 2020 02:45
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 5, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 2d4b69d to 2a715bf Compare December 5, 2020 19:14
alliepiper
alliepiper approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple potential issues to be aware of pointed out inline. We should handle the case where no arches are detected before merging, but otherwise 👍

alliepiper
alliepiper suggested changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as "request changes" to block merging, since the "no GPUs detected" case is probably very important on the CI nodes.

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 2a715bf to 903648e Compare December 10, 2020 23:19
@brycelelbach brycelelbach changed the title Auto detect compute architectures and add a GPU node configuration Add gpuCI GPU testing, automatic GPU detection, and support for more compilers Dec 11, 2020
@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 903648e to 74ee66f Compare December 11, 2020 19:27
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 11, 2020

Okay, the "ALL" case is handled now.

@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 11, 2020

ok to test

alliepiper
alliepiper reviewed Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is github up to date with your local branch? Some changes seem to be missing.

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 74ee66f to ce65b6b Compare December 11, 2020 23:20
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 11, 2020

I've pushed the latest changes.

alliepiper
alliepiper approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@alliepiper alliepiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, can't wait to try it out! 🥳

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from ce65b6b to 077d802 Compare December 11, 2020 23:32
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 12, 2020

I'm gonna wait for @raydouglass to explicitly sign-off because this will actually turn on more configs.

raydouglass
raydouglass suggested changes Dec 14, 2020
View reviewed changes
@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch 2 times, most recently from d4065fd to 3bc0471 Compare December 15, 2020 00:34
@raydouglass
Copy link
Contributor

raydouglass commented Dec 15, 2020

run tests

I've enabled the GPU build, so let's see how it goes.

raydouglass
raydouglass previously requested changes Dec 15, 2020
View reviewed changes
@brycelelbach brycelelbach mentioned this pull request Dec 18, 2020
Closed
@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 90be0d3 to d23f4e0 Compare December 19, 2020 19:24
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 19, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch 2 times, most recently from 2348363 to 87eeb41 Compare December 19, 2020 20:42
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 19, 2020

run tests

2 similar comments
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 19, 2020

run tests

@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 19, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 87eeb41 to 4f4381f Compare December 21, 2020 18:03
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 21, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 4f4381f to 35544f7 Compare December 21, 2020 18:40
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 21, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 35544f7 to 4b6919d Compare December 21, 2020 19:20
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 21, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 4b6919d to efd2cdb Compare December 21, 2020 19:44
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 21, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from efd2cdb to 2196bf4 Compare December 21, 2020 20:20
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 21, 2020

run tests

@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 21, 2020

GPU tests are still failing - for some reason, the NVIDIA runtime doesn't seem to be enabled by gpuCI. That will have to wait until after the break.

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 2196bf4 to da78e6d Compare December 21, 2020 21:57
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 21, 2020

run tests

1 similar comment
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 23, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from da78e6d to 41d5a9c Compare December 23, 2020 21:18
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 23, 2020

run tests

@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from 41d5a9c to e80efdc Compare December 23, 2020 21:22
@brycelelbach
Copy link
Collaborator Author

brycelelbach commented Dec 23, 2020

run tests

@brycelelbach
Add gpuCI GPU testing, automatic GPU detection, and support for more …
29abeb7 
…compilers:

* CMake: Add support for detecting the compute archs of the GPUs in your system
  at configure time.
* CMake: Update FindTBB.cmake to support the newer oneTBB.
* gpuCI: Add a GPU node configuration that builds and tests as little as possible.
* gpuCI: Cleanup logic for different build and test configurations.
* gpuCI: Fix an unfortunate typo in `determine_build_parallelism.bash` which
  led to the parallelism level not being set.
* gpuCI: Add support for NVC++.
* gpuCI: Update to CUDA 11.1 and Ubuntu 20.04.
* gpuCI: Add NVC++ and ICC configurations to the CPU axis file.
* gpuCI: Add a GPU axis file.
* gpuCI: Increase the desired memory per build thread to 4GB.
* gpuCI: Add a -j switch which controls build parallelism to `ci/local/build.bash`.
* gpuCI: Add support for CMake build types.
@brycelelbach brycelelbach force-pushed the feature/auto-detect-archs branch from e80efdc to 29abeb7 Compare December 24, 2020 20:17
@brycelelbach brycelelbach merged commit 5fa7484 into main Dec 24, 2020
@brycelelbach brycelelbach deleted the feature/auto-detect-archs branch December 24, 2020 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@raydouglass raydouglass Awaiting requested review from raydouglass

1 more reviewer

@alliepiper alliepiper alliepiper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

3 participants

@brycelelbach @raydouglass @alliepiper