Enable more warning flags. by alliepiper · Pull Request #1359 · NVIDIA/thrust

alliepiper · 2020-12-11T02:44:36Z

Fixes NVIDIA/cub#228.
Fixes #1273.

Requires NVIDIA/cub#249.

alliepiper · 2020-12-11T02:45:57Z

run tests

alliepiper · 2020-12-11T13:49:05Z

run tests

cmake/ThrustBuildCompilerTargets.cmake

testing/functional_placeholders_bitwise.cu

testing/set_symmetric_difference.cu

thrust/system/cuda/detail/future.inl

thrust/system/detail/generic/sequence.inl

brycelelbach · 2021-01-01T03:36:26Z

thrust/system/detail/generic/shuffle.inl

-                                              const uint64_t key) const {
-    uint64_t hash0 = thrust::random::taus88(value)();
+                                              const uint64_t key_) const {
+    uint64_t hash0 = thrust::random::taus88(static_cast<uint32_t>(value))();


Can this be std::uint32_t and std::uint64_t?

No -- tau88 only accepts uint32_t inputs. This doesn't change anything, it just makes the implicit cast explicit and silences the conversion warnings.

I checked with the shuffle author about this change and he was fine with it, it shouldn't affect the results.

I just meant stick std:: in front of the types.

alliepiper · 2021-01-22T23:13:11Z

run tests

alliepiper · 2021-01-23T03:56:27Z

run tests

alliepiper · 2021-01-25T19:40:51Z

run tests

alliepiper · 2021-01-25T20:02:02Z

run tests

alliepiper · 2021-01-26T20:13:41Z

run tests

alliepiper · 2021-01-26T21:00:08Z

DVS CL: 29547313

alliepiper · 2021-01-26T22:40:48Z

DVS CL 29547580

run tests

alliepiper · 2021-02-10T03:46:42Z

run tests

Replaces the macros for: - THRUST_CONSTEXPR - THRUST_OVERRIDE - THRUST_DEFAULT - THRUST_NOEXCEPT - THRUST_FINAL

MSVC /W4 issues warnings when this could be used but isn't. We still have to suppress the MSVC warnings since there's no way to silence them pre-C++17.

Anonymous structs are C features. In C++, they're non-portable compiler extensions. These only seemed to pop up in CUB-style `TempStorage` objects, I just picked some reasonable sounding names for them.

Some tests throw exceptions unconditionally and this warning is safe to ignore in such cases. Added a `thrust.silence_unreachable_code_warnings` interface target to collect various compiler flags that disable these warnings. This can be linked selectively in a per-test `<testname>.cmake` file to only disable warnings on the tests where this behavior is expected.

The unittest_static_assert test needs to be disable for TBB/OMP hosts, too.

The `cuda_std_17` compile feature is broken for MSVC when CMake < 3.18.3.

The expression `(n + d - 1) / d` can overflow the numerator. The new method avoids that. See NVIDIA/cub#221 for reference.

Also removed some obsolete C++98 checks.

Includes a workaround that fixes NVIDIA#1273.

alliepiper marked this pull request as draft December 11, 2020 02:45

alliepiper added this to the 1.12.0 milestone Dec 11, 2020

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from 7d6d247 to 5413017 Compare December 11, 2020 13:48

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch 2 times, most recently from 21bbf7b to e67f342 Compare December 11, 2020 21:04

alliepiper linked an issue Dec 11, 2020 that may be closed by this pull request

[NVBug 3129879] MSVC debug iterators give dreaded "[subobject]" nvcc execution space warnings #1273

Closed

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from e67f342 to ef350b0 Compare December 15, 2020 21:31

brycelelbach reviewed Jan 1, 2021

View reviewed changes

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from ef350b0 to b9e6052 Compare January 22, 2021 23:08

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch 2 times, most recently from 1a0ff3a to 46db957 Compare January 23, 2021 02:55

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from 46db957 to ec1df9f Compare January 25, 2021 19:40

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from ec1df9f to b3b8a67 Compare January 25, 2021 20:01

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from b3b8a67 to eab18bc Compare January 26, 2021 20:13

alliepiper marked this pull request as ready for review January 26, 2021 21:00

alliepiper added testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI passed Passed gpuCI testing. labels Jan 26, 2021

alliepiper linked an issue Jan 26, 2021 that may be closed by this pull request

Compiler warning with counting_iterator in MSVC #1091

Closed

alliepiper mentioned this pull request Jan 26, 2021

std::size_t to int conversion warnings in thrust::transform_reduce #974

Closed

alliepiper linked an issue Jan 26, 2021 that may be closed by this pull request

std::size_t to int conversion warnings in thrust::transform_reduce #974

Closed

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from eab18bc to 8fce62d Compare January 26, 2021 22:25

alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). testing: gpuCI passed Passed gpuCI testing. and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). testing: gpuCI in progress Started gpuCI testing. labels Feb 10, 2021

alliepiper added 22 commits February 16, 2021 13:50

Bump CUB for compliance / warning fixes.

2c2d288

Remove stand-in macros for C++11 features and use them directly.

24c19e5

Replaces the macros for: - THRUST_CONSTEXPR - THRUST_OVERRIDE - THRUST_DEFAULT - THRUST_NOEXCEPT - THRUST_FINAL

Add THRUST_IF_CONSTEXPR.

28fcb12

MSVC /W4 issues warnings when this could be used but isn't. We still have to suppress the MSVC warnings since there's no way to silence them pre-C++17.

Name unnamed structs.

b2b093e

Anonymous structs are C features. In C++, they're non-portable compiler extensions. These only seemed to pop up in CUB-style `TempStorage` objects, I just picked some reasonable sounding names for them.

Fix assorted shadowed variable warnings.

a04dccc

Mark global test variable used on GCC.

754fda8

Extend the partially_implemented logic to restrict by host, too.

c426f67

The unittest_static_assert test needs to be disable for TBB/OMP hosts, too.

Fix C++17 + NVCC + MSVC + CMake.

1fe6639

The `cuda_std_17` compile feature is broken for MSVC when CMake < 3.18.3.

Fix various numeric conversion warnings.

5d93f14

Add missing private header inclusion.

33fa165

Use invoke_result instead of result_of on C++17.

cdfbc82

Remove dead code.

c6446db

Remove unreachable code from test case.

fd87fcf

Use new cub::DivideAndRoundUp util to avoid overflow errors.

8f876ba

The expression `(n + d - 1) / d` can overflow the numerator. The new method avoids that. See NVIDIA/cub#221 for reference.

Update shuffle.inl to use std:: type aliases instead of C versions.

20d8571

Also removed some obsolete C++98 checks.

Remove dead code.

e4380f1

Refactor to avoid a static_cast in example code.

e167dce

Clean up whitespace.

6ab779a

Refactor out some calls to rand() in tests.

91b4b43

Fix whitespace.

6b6b7f5

Enable more compiler warning flags.

f3e511f

Includes a workaround that fixes NVIDIA#1273.

alliepiper force-pushed the enh/pedantic_flags/gh.cub228 branch from d729e2d to f3e511f Compare February 16, 2021 18:51

alliepiper merged commit df8afb8 into NVIDIA:main Feb 16, 2021

alliepiper deleted the enh/pedantic_flags/gh.cub228 branch February 16, 2021 18:52

Conversation

alliepiper commented Dec 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alliepiper commented Dec 11, 2020

Uh oh!

alliepiper commented Dec 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brycelelbach Jan 1, 2021

Choose a reason for hiding this comment

Uh oh!

alliepiper Jan 1, 2021

Choose a reason for hiding this comment

Uh oh!

brycelelbach Feb 8, 2021

Choose a reason for hiding this comment

Uh oh!

alliepiper Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

alliepiper commented Jan 22, 2021

Uh oh!

alliepiper commented Jan 23, 2021

Uh oh!

alliepiper commented Jan 25, 2021

Uh oh!

alliepiper commented Jan 25, 2021

Uh oh!

alliepiper commented Jan 26, 2021

Uh oh!

alliepiper commented Jan 26, 2021

Uh oh!

alliepiper commented Jan 26, 2021

Uh oh!

alliepiper commented Feb 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alliepiper commented Dec 11, 2020 •

edited

Loading