This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Use CUB version of merge sort #1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
run tests |
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
from
f00fabe to
a212bb6
Compare
Collaborator
Author
|
run tests |
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
from
a212bb6 to
6cc34dc
Compare
Collaborator
Author
|
run tests |
Collaborator
Author
|
DVS: 30345552 |
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
from
6cc34dc to
83eaecc
Compare
Collaborator
Author
|
run tests |
alliepiper
added
P1: should have
alliepiper
added
P2: nice to have
Collaborator
|
@senior-zero Let's try to get this in for 1.15 if DVS is passing and it's ready to merge, but this is super low priority if it's going to take actual effort. |
alliepiper
approved these changes
Oct 14, 2021
thrust/system/cuda/detail/sort.h
Outdated
| } | ||
|
|
||
| for (int pass = 0; pass < num_passes; ++pass, ping = !ping) | ||
| if (STABLE::value) |
Collaborator
There was a problem hiding this comment.
These may need to be THRUST_IF_CONSTEXPR if tests complain about the constexpr arg.
Collaborator
Author
|
run tests |
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
from
13707fb to
5a17e55
Compare
Collaborator
Author
|
run tests |
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
from
5a17e55 to
f7e39a8
Compare
Collaborator
Author
|
run tests |
Collaborator
Author
|
DVS CL: 30537652 |
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
2 times, most recently
from
b16eae9 to
ce4c107
Compare
Collaborator
Author
|
run tests |
Collaborator
|
Hoping DVS behaves this time 😅 DVS CL: 30549730 |
Collaborator
|
The DVS builds are all timing out with this update, and gpuCI seems to be taking about an hour longer than before. We should track down why and fix this before merging. Moving to 1.16 since this isn't urgent for 1.15. |
alliepiper
suggested changes
Oct 20, 2021
Collaborator
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
Need to track down compile time increases between old and new merge sort implementations.
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
from
ce4c107 to
9dd2f22
Compare
Collaborator
Author
|
run tests |
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
from
9dd2f22 to
6192d9a
Compare
Collaborator
Author
|
run tests |
gevtushenko
force-pushed
the
main-feature/github/use_cub_merge_sort
branch
from
6192d9a to
91d5e6c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Thrust version of merge sort and uses CUB one instead.