libfetchers/git: Include revCount even if worktree is dirty#15458
Open
aionescu wants to merge 1 commit intoNixOS:masterfrom
Open
libfetchers/git: Include revCount even if worktree is dirty#15458aionescu wants to merge 1 commit intoNixOS:masterfrom
revCount even if worktree is dirty#15458aionescu wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
Bot
added
the
fetching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR makes it so
revCountis included for dirty Git repos too. The main motivation is to have therevCountavailable oninputs.selfwhen building a flake from a dirty Git repo.Plus, the
lastModifiedtimestamp of therevis already included for dirty repos, so I think it's justified to include therevCounttoo.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.