Fix SOAP fault parsing

[evpaassen]

Currently, when an HTTP 500 is returned, an exception is raised about a missing SOAP header. This is because SOAP faults from EWS don't contain headers. Instead of trying to parse the SOAP message the web existing exception handling logic should be called here.

I also cleaned up the ServiceRequestBase related classes a little bit, before the fix could be done.

[vboctor]

Order alphabetically.

[evpaassen]

IntelliJ IDEA orders javax.* imports before java.* imports by default. I'm not sure we want to change this as long as the coding standards for this project are undefined.

[vboctor]

Makes sense.

[vboctor]

+1 - will have another look once comments are addressed.

[evpaassen]

Other comments are addressed.

[evpaassen]

I also removed the FIXME's and created PR #27 to remove the unused and incorrect methods.

[vboctor]

Please push the commits that address the pull request feedback so that it can be viewed as part of the pull request. Thanks.

[evpaassen]

Please push the commits that address the pull request feedback so that it can be viewed as part of the pull request. Thanks.

They already are. I rebased the fixes into the commits where they belong. You can click on the outdated commits in this PR to see that the issues have been addressed.

[evpaassen]

I'm not sure we should wrap the exception here either. The problem is the exception gets wrapped two or three times by this class and the problem with wrapping exceptions is that it makes handling the real exception much harder. Why are exceptions wrapped anyway?

[vboctor]

Please update this pull request to merge automatically and I'll merge it.

[evpaassen]

I addressed the issue you mentioned in your last comment about declaration and initialization of the request variable and rebased all commits on the latest version of master.