This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Only call handle response once in HandingServiceRequestBase #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
If you are deleting this copy of the handleResponseObject() call, then you should uncomment the call with the if-block which calls it when tracing is ON.
Contributor
|
Thanks @bpot for your contribution. It would be great if you can open an issue for this bug and reference it from the pull request. I've also added a comment about the code change that will need your attention. |
bpot
force-pushed
the
fix_duplicate_notifications
branch
from
4366945 to
7fb0bb6
Compare
… streaming events.
Contributor
Author
vboctor
added a commit
that referenced
this pull request
Sep 24, 2014
Fix #75: Duplicate callbacks when streaming events
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents duplicate notifications when streaming events.
I also cleaned up some whitespace.