This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Issue #84 - MapiTypeConverterMapEntry.validateValueAsArray is wrong #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ExchangeService, method internalGetAttachments:
List propsArray = new ArrayList();
for (PropertyDefinitionBase propertyDefinitionBase :
additionalProperties)
If addtionalProperties is null (and it can be), this throws a
NullPointerException.
A check for null is done here:
if (additionalProperties != null) {
request.getAdditionalProperties().addAll(propsArray);
}
This check should be done earlier.
And
propsArray.add(additionalProperties);
This will result in adding a list to another list and later on result in
a ClassCastException.
It should be:
for (PropertyDefinitionBase propertyDefinitionBase :
additionalProperties)
{
propsArray.add(propertyDefinitionBase);
}
There is a loop through an ArrayList written as: for (int index = 0; index <= array.size(); index++) It should be written as: for (int index = 0; index < array.size(); index++)
The method validateValueAsArray is completely wrong. For starters, arrays are not instances of the class Array. Secondly, extended properties of “arrays” have been implemented by the EWS API using ArrayList which is not an array, its a list.
This reverts commit 3031da5.
This reverts commit 8aee4f2.
…wrong" This reverts commit 24adcb4.
avromf
changed the title
avromf
changed the title
avromf
changed the title
avromf
changed the title
avromf
changed the title
Contributor
|
@Avrom I recommend that you squash the changes on this branch into a new branch so that there is a single commit that has the fix for the bug. Then submit that as a new pull request. For example:
Then submit a pull request from Issue84 branch. As part of the pull request preview, make sure that there is a single commit that has the change related to this specific bug. Hope this helps. |
Contributor
Author
|
@vboctor I did create a separate branch for this issue but it seems to still contain my original commits. |
Contributor
Author
|
@vboctor I tried this for another issue but the "squash" did not seem to work. |
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.