align the dygraph behavior of simnet with static graph#4662
Open
FrostML wants to merge 1 commit intoPaddlePaddle:dev-staticfrom
Open
align the dygraph behavior of simnet with static graph#4662FrostML wants to merge 1 commit intoPaddlePaddle:dev-staticfrom
FrostML wants to merge 1 commit intoPaddlePaddle:dev-staticfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
【WIP】In dygraph similarity_net, list problems before this fix:
fluid.layers.reshape(size=[-1, 1])to guarantee that the shape of Embedding's input is [xx, xx, 1], which is NOT recommended and NOT proper for batch input.fluid.layers.reduce_sumwhilesequence_last_stepfor static graph.Due to pre-commit, code format has been changed. Mark changes as follow to help review.
paddle_layers.py

run_classifier.py
delete all
fluid.layers.reshapeutils.py
