Skip to content

An unsubscribed AtomicObservableSubscription.wrap() unsubscribes its argument#230

Merged
benjchristensen merged 1 commit intoReactiveX:masterfrom
johngmyers:wrap-unsubscribed
Apr 16, 2013
Merged

An unsubscribed AtomicObservableSubscription.wrap() unsubscribes its argument#230
benjchristensen merged 1 commit intoReactiveX:masterfrom
johngmyers:wrap-unsubscribed

Conversation

@johngmyers
Copy link
Contributor

Fixes #210

@cloudbees-pull-request-builder

RxJava-pull-requests #86 SUCCESS
This pull request looks good

@benjchristensen
Copy link
Member

Interesting use case ... suggests either the wrap is being done at the wrong time or a race condition where a Subscription is being returned before a subscription is invoked - not sure when that would occur but there's probably some use case I'm not thinking of!

benjchristensen added a commit that referenced this pull request Apr 16, 2013
An unsubscribed AtomicObservableSubscription.wrap() unsubscribes its argument
@benjchristensen benjchristensen merged commit d0118b2 into ReactiveX:master Apr 16, 2013
@johngmyers johngmyers deleted the wrap-unsubscribed branch April 16, 2013 23:55
@johngmyers
Copy link
Contributor Author

Per #210, the TestObservable sequence makes its last onNext() notification on another thread before TakeWhile.call() can stuff the ItemObserver's subscription into the AtomicObservableSubscription. Thus the AtomicObservableSubscription gets unsubscribed before the wrap() call.

rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
An unsubscribed AtomicObservableSubscription.wrap() unsubscribes its argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants