Swing scheduler

[jmhofer]

I've added a Swing-specific scheduler to RxJava. However, it probably doesn't belong to rxjava-core and therefore, I've created a subfolder named extensions with currently one single subproject rxjava-swing with currently one single class SwingScheduler.

I've tried to create a build for this, too, but I'm not very familiar with Gradle, so somebody should probably check that it's okay like this.

Also, I'm not very happy with the subfolder name (extensions). Maybe somebody has a better idea for a more specific name?

[cloudbees-pull-request-builder]

RxJava-pull-requests #115 FAILURE
Looks like there's a problem with this pull request

[jmhofer]

The failing test on Cloudbees says that the test should probably use longer delays...

[cloudbees-pull-request-builder]

RxJava-pull-requests #116 FAILURE
Looks like there's a problem with this pull request

[jmhofer]

I'm not the only one who used too short delays in the tests. ;)

[benjchristensen]

This is a good addition - I imagine we'll also end up with something like SwingObservables for utility methods wrapping listeners and other Swing based behavior being added to this module.

On Hystrix I called it hystrix-contrib (https://github.com/Netflix/Hystrix/tree/master/hystrix-contrib). Not sure if that's better or worse.

We could go with:

• extensions
• rxjava-ext
• rxjava-extensions
• rxjava-contrib

None of these affects the Maven Central published name though, so it's just the organization of the code. This module in /extensions/rxjava-swing will be published as rxjava-swing.

[benjchristensen]

For the test delays I've started to try and use CountDownLatch wherever I can so that tests are deterministic and I control when things wait and proceed so it runs as fast as the CPU and I don't have to set really long delays to account for different machines and non-deterministic scheduling.

When specifically testing a scheduler though it can be tricky sometimes to do it this way :-)

[daveray]

I vote for rxjava-contrib if only to be consistent with hystrix. Also
rxjava-extensions sounds like plugins or something rather than just
additional helper code written on top of rxjava.

Dave

On Thu, May 2, 2013 at 9:01 AM, Ben Christensen notifications@github.amrom.workers.devwrote:

This is a good addition - I imagine we'll also end up with something like
SwingObservables for utility methods wrapping listeners and other Swing
based behavior being added to this module.

On Hystrix I called it hystrix-contrib (
https://github.com/Netflix/Hystrix/tree/master/hystrix-contrib). Not sure
if that's better or worse.

We could go with:

• extensions
• rxjava-ext
• rxjava-extensions
• rxjava-contrib

None of these affects the Maven Central published name though, so it's
just the organization of the code. This module in /extensions/rxjava-swing
will be published as rxjava-swing.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/254#issuecomment-17347038
.

[jmhofer]

I'm good with rxjava-contrib, too.

[benjchristensen]

I'm also okay with rxjava-contrib.

Do you want to make the change @jmhofer, or do you want me to do it as a custom merge?

[jmhofer]

I can do it, give me an hour, not at my computer right now.

[cloudbees-pull-request-builder]

RxJava-pull-requests #117 SUCCESS
This pull request looks good