Added Dockerfile for building & running the site using Docker#372
Merged
DavidMGross merged 3 commits intoReactiveX:developfrom Jun 7, 2018
r3h0:develop
Merged
Added Dockerfile for building & running the site using Docker#372DavidMGross merged 3 commits intoReactiveX:developfrom r3h0:develop
DavidMGross merged 3 commits intoReactiveX:developfrom
r3h0:develop
Conversation
This allows contributors to get going right away (assuming they have Docker) and also provides a certain measure of reproducibility.
This passes in no build context and instead mounts the current folder as a volume so jekyll's --watch mode works like normal.
I decided that for future maintainability it might be best to leave the version off of the base image. If we end up using Docker a lot more, we can be more explicit about which versions we're using.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I started on the reactivex.github.io project yesterday, I didn't have most of the requisite tools. By using a Docker image, I think new contributors will be able to start contributing faster (assuming they have Docker). This provides a certain degree of reproducibility as well, especially if we make the Dockerfile more restrictive to the versions of each required dependency.
If desired, I can add a docker-compose file or bash script to make the build & run command less verbose.