tobiko-app image size reduced from 3GB to 1.3GB#2589
tobiko-app image size reduced from 3GB to 1.3GB#2589singulart wants to merge 1 commit intoSQLMesh:mainfrom singulart:app-image-size
Conversation
| RUN pip3 install -e .[dev,web] | ||
|
|
||
| RUN pip install -e .[dev,web] | ||
| FROM python:3.11-slim-bullseye as app-image |
There was a problem hiding this comment.
why are you referencing python 3.11 both times? can you explain a bit about what this pr is doing?
There was a problem hiding this comment.
The Dockerfile was updated the following way:
- The "slimmer" base image
python:3.11-slim-bullseyewas used. - Multi-stage build approach was used: https://docs.docker.com/build/building/multi-stage
The 2) is why the image is being referenced twice. Hope that helps! Let me know if you need more clarity on this ;)
|
@singulart thanks for the PR. since this docker image is used for development and never shipped to the user, I don't think we need to add complexity to reduce the size of the image. so for now i'm going to close this pr. |
Sure @tobymao! Should the Docker image size become an issue going forward, you know how to solve it. Good luck! |
|
thanks so much |
2 participants
Hey, Team! Came across your repository and thought I could help in optimizing the Docker image size.