Conversation
eakmanrq
reviewed
Dec 8, 2022
|
|
||
| def test_serialize_env_error() -> None: | ||
| with pytest.raises(SQLMeshError) as e: | ||
| serialize_env({"pandas": pd}, module="pandas") |
Collaborator
There was a problem hiding this comment.
This wouldn't apply to pandas though right since that is a third party module?
Contributor
Author
There was a problem hiding this comment.
yea, but this test pretends like we are pandas
Collaborator
There was a problem hiding this comment.
Yeah it just could be confusing for future people reading this. Maybe make a comment explaining that.
tobymao
force-pushed
the
toby/raise_import
branch
from
2cbd804 to
0d1f6e3
Compare
tobymao
force-pushed
the
toby/raise_import
branch
from
0d1f6e3 to
e6f455d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.