Skip to content

Minor fixups #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 1 commit into from
Dec 9, 2022
Merged

Minor fixups #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions sqlmesh/core/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,10 +375,8 @@ def expression(self) -> exp.Column | exp.Tuple:
column = exp.to_column(self.column)
if not self.format:
return column
t = exp.Tuple(expressions=[column])
if self.format:
t.append("expressions", exp.Literal.string(self.format))
return t

return exp.Tuple(expressions=[column, exp.Literal.string(self.format)])


class ModelMeta(PydanticModel):
Expand Down Expand Up @@ -1013,7 +1011,6 @@ def exec_python(
assert self.time_column

if pyspark and isinstance(df, pyspark.sql.DataFrame):
self.convert_to_time_column(end)
df = df.where(
f"""
{self.time_column.column} BETWEEN
Expand Down