Fix key error when removing a dependency which doesn't exist when concurrently applying a function to a DAG#41
Merged
izeigerman merged 1 commit intomainfrom Dec 11, 2022
Conversation
izeigerman
force-pushed
the
fix-concurrent-apply-to-dag
branch
from
6f5cb7e to
cfe08b1
Compare
tobymao
approved these changes
Dec 10, 2022
…currently applying a function to a DAG
izeigerman
force-pushed
the
fix-concurrent-apply-to-dag
branch
from
cfe08b1 to
50113bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues:
.remove()to.discard().finished_futurewhen all tasks have been finished as opposed to when all tasks have been submitted.