raise tollerance of test #245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for SciML/OrdinaryDiffEq.jl#1763. The previous tolerance was overly strict.
Member
|
So SciML/OrdinaryDiffEq.jl#1763 introduces regressions? |
Member
Author
|
It is slightly less accurate when the timespan is greater than 1, but the policy of picking an initial dt that is fixed makes a lot less sense than picking one proportional to the timespan. |
Member
|
Because of the nested structure (nesting ODE solvers inside ODE solvers) tiny regressions in OrdinaryDiffEq are amplified in DelayDiffEq. So I'm also worried about small regressions. Could one introduce a branch such that larger time spans are still handled in the same way? |
Member
Author
|
This was actually nu-necessary. I only need this change for DAEs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for SciML/OrdinaryDiffEq.jl#1763. The previous tolerance was overly strict.