Fix UndefRefError with default solver (fixes #329) #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DefaultODEAlgorithm()toTsit5()as a workaround for OrdinaryDiffEqCore compatibility issueBackground
In v5.57, support for
DefaultODEAlgorithmwas added to DelayDiffEq. However, this introduced a bug where theDefaultCachestructure used byDefaultODEAlgorithmis incompatible with OrdinaryDiffEqCore's interpolation code, causing anUndefRefErrorwhen evaluating the history function.The error occurs because:
DefaultODEAlgorithmcreates a composite algorithm withDefaultCacheDefaultCachestores individual cache fields (cache1, cache2, etc.) rather than a caches arrayode_interpolationfunction doesn't know how to handleDefaultCacheproperlyt-1, it triggers the UndefRefErrorSolution
This PR changes the default solver from
DefaultODEAlgorithm()toTsit5(). This is a temporary workaround until OrdinaryDiffEqCore adds proper support forDefaultCachein its interpolation routines.Test Results
Tsit5()Future Work
A proper fix would require changes to OrdinaryDiffEqCore to handle
DefaultCachein theode_interpolationfunction. This PR provides an immediate fix for users experiencing the issue.🤖 Generated with Claude Code