Fix master tests based on changes in OrdinaryDiffEq ecosystem #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem This commit addresses multiple test failures in DelayDiffEq master branch: 1. **Fix YAML syntax error in .github/workflows/Tests.yml**: - Corrected malformed include matrix entry that was causing CI failures - Fixed nested list syntax for version specification 2. **Fix implicit imports in src/DelayDiffEq.jl**: - Added explicit imports for OrdinaryDiffEqDefault and OrdinaryDiffEqFunctionMap modules - Added explicit import for Reexport module to resolve ExplicitImports.jl test failures - Ensures compatibility with stricter import requirements in OrdinaryDiffEq ecosystem 3. **Update ExplicitImports test configuration**: - Added ignore parameter for @reexport macro to prevent false positives - The @reexport macro is correctly imported but ExplicitImports has known issues with macro detection These changes restore CI functionality and ensure DelayDiffEq tests pass with the latest OrdinaryDiffEq dependencies. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Update test imports to use OrdinaryDiffEqCore instead of OrdinaryDiffEq for: - current_interpolant - loopheader! - perform_step! - loopfooter! These functions were moved from OrdinaryDiffEq to OrdinaryDiffEqCore in recent versions. This fixes remaining Interface test failures and ensures compatibility with the updated OrdinaryDiffEq ecosystem. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Contributor
Author
Additional Fixes AppliedAfter running local tests, I found and fixed additional compatibility issues: OrdinaryDiffEq Function RelocationsSeveral functions used in the history function tests have been moved from to :
Test Results✅ History Function Tests: Now pass completely (81/81 tests passing) These fixes address the remaining test failures in the Interface test group and ensure compatibility with the restructured OrdinaryDiffEq ecosystem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple test failures in DelayDiffEq.jl master branch that were preventing CI from passing. The failures were caused by:
Changes Made
1. Fix CI Workflow Configuration (.github/workflows/Tests.yml)
2. Update Import Declarations (src/DelayDiffEq.jl)
OrdinaryDiffEqDefaultandOrdinaryDiffEqFunctionMapmodulesReexportmodule3. Update QA Test Configuration (test/qa/qa_tests.jl)
ignoreparameter tocheck_no_implicit_importsfor the@reexportmacroTest Results
Verification
The changes were tested locally and resolve the specific test failures seen in PR #332. The DelayDiffEq package compiles successfully and the explicit imports test suite passes.
🤖 Generated with Claude Code