Add get_tstops interface for PeriodicCallback support #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement DiffEqBase.get_tstops, DiffEqBase.get_tstops_array, and DiffEqBase.get_tstops_max for DDEIntegrator to enable PeriodicCallback and other callbacks that rely on these interfaces. Fixes SciML#341 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ChrisRackauckas
approved these changes
Dec 5, 2025
ChrisRackauckas-Claude
force-pushed
the
fix-periodic-callback-tstops
branch
from
03d71ba to
62c732e
Compare
The strict ≈ comparison was too tight for cross-platform consistency, especially on 32-bit systems. Using explicit rtol=1e-4 for all comparisons to allow for floating-point differences between scalar and in-place solutions across different architectures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ChrisRackauckas-Claude
force-pushed
the
fix-periodic-callback-tstops
branch
from
62c732e to
ae2cbc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DiffEqBase.get_tstops,DiffEqBase.get_tstops_array, andDiffEqBase.get_tstops_maxforDDEIntegratorPeriodicCallbackand other callbacks that rely on the tstops interfacePeriodicCallbackwith DDE problemsFixes #341
Test plan
PeriodicCallbackintest/integrators/events.jl🤖 Generated with Claude Code