Feature/bucket sort#97
Open
awais019 wants to merge 1 commit into
Open
Conversation
appgurueu
requested changes
Feb 4, 2023
Contributor
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
- Remove the addition of SelectionSort in this PR.
- Your complexity analysis of BucketSort is wrong. BucketSort runs in O(max(A) - min(A)) time and space complexity, no matter how the input array is permuted.
awais019
force-pushed
the
feature/bucket-sort
branch
2 times, most recently
from
649db69 to
3fd48cf
Compare
Contributor
Author
|
I did some changes kindly review them and let me know If I'm still wrong. |
appgurueu
reviewed
Feb 5, 2023
| @@ -0,0 +1,21 @@ | |||
| import { bucketSort } from "../bucket_sort"; | |||
|
|
|||
| describe("Testing Selection sort", () => { | |||
Contributor
There was a problem hiding this comment.
Don't copy/duplicate test cases. You should apply the same tests to both selectionsort and bucketsort.
Contributor
Author
There was a problem hiding this comment.
It's fixed check it now.
Contributor
There was a problem hiding this comment.
I'm afraid it still isn't fixed. Bucket sort and selection sort both solve the same problem, so when you're doing black-box testing, they should both get the same test cases. In addition to that you may do some white-box testing specific to each, but currently the test cases are duplicated.
awais019
force-pushed
the
feature/bucket-sort
branch
from
3fd48cf to
3ae40ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just added bucket sort. That is a small step towards completing this repo for implementation of all algorithms and data structures in typescript.