Skip to content

Support implicit field keys#319

Open
jparise wants to merge 1 commit into
Thriftpy:developfrom
jparise:implicit-field-keys
Open

Support implicit field keys#319
jparise wants to merge 1 commit into
Thriftpy:developfrom
jparise:implicit-field-keys

Conversation

@jparise

@jparise jparise commented Dec 1, 2017

Copy link
Copy Markdown
Contributor

Fields without explicit keys are automatically assigned starting from -1
and working their way down. Implicit field keys are deprecated by Apache
Thrift, but supporting them gives us greater Thrift IDL compatibility.

Fields without explicit keys are automatically assigned starting from -1
and working their way down. Implicit field keys are deprecated by Apache
Thrift, but supporting them gives us greater Thrift IDL compatibility.
@jparise

jparise commented Dec 18, 2017

Copy link
Copy Markdown
Contributor Author

@maralla and @hit9, do you think this is something you'd consider for review and merging? It's an old Thrift feature, but we have some .thrift files that rely on it, and we unfortunately can't just add the explicit negative key values to the IDL files without triggering other warnings.

@jparise

jparise commented Jan 9, 2018

Copy link
Copy Markdown
Contributor Author

@maralla and @hit9, just wanted to follow-up and ask if this is still under consideration.

@jparise

jparise commented Apr 9, 2018

Copy link
Copy Markdown
Contributor Author

Sorry to bother @lxyu @hit9 @maralla, but would you consider merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant