Use errors.As()/errors.Is() syntax#108
Use errors.As()/errors.Is() syntax#108jeffwidman wants to merge 1 commit intoVividCortex:gh-pagesfrom jeffwidman:patch-1
Conversation
Use the new `errors.Is()`/`errors.As()` syntax from `go 1.13`.
|
tagging @pmatseykanets for visibility... looks like this repo has a few PR's that could be quickly merged or rejected in addition to this one... |
|
nudge @efepapa @gkristic-vc |
gkristic-vc
left a comment
gkristic-vc
left a comment
There was a problem hiding this comment.
Hi Jeff. Thanks! I am not particularly inclined to this use of Is, though. The database/sql package has a well defined contract and errors are part of it. Well defined errors like sql.ErrNoRows can't be wrapped at this point without breaking the API. On the flip side, if an inner error was sql.ErrNoRows and the package decided to return something else (as to make Is different than ==), then Is would actually introduce a dependency on the internal implementation. Would you agree?
The use of As to catch specific driver errors makes more sense, in my opinion, although as of 1.14.2 the database/sql package doesn't seem to be wrapping errors at all. If it did, it'd likely break many applications that check for driver errors directly. So I'm not sure that this will ever be changed, at least for Go 1.x.
|
No problem. I don't fully agree with your reasoning, but it's your project, so your call. |
2 participants
Use the new
errors.Is()/errors.As()syntax fromgo 1.13.