Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Added a link to the official list of drivers#93

Closed
strixy wants to merge 1 commit intoVividCortex:gh-pagesfrom
strixy:patch-1
Closed

Added a link to the official list of drivers#93
strixy wants to merge 1 commit intoVividCortex:gh-pagesfrom
strixy:patch-1

Conversation

@strixy
Copy link
Copy Markdown

@strixy strixy commented Jul 11, 2018

I thought it would be helpful to add a link to a list of other drivers that are available. I thought it best to link to the official list, but feel free to suggest a different / better source. I also edited out a couple comma splices and attempted to use less opinionated language while maintaining the same emphasis on the best practices described.

I thought it would be helpful to add a link to a list of other drivers that are available. I thought it best to link to the official list, but feel free to suggest a different / better source. I also edited out a couple comma splices and attempted to use less opinionated language while maintaining the same emphasis on the best practices described.
@xaprb
Copy link
Copy Markdown
Contributor

xaprb commented Oct 29, 2018

Hi, and thanks for the contribution. I'd be happy to accept the added link, but the PR is doing three things at once so it's difficult to manage. The comma editing is not grammatically correct. Those aren't comma splices. Re: tone and phrasing suggestions, if you feel it's too opinionated, can you point to what's wrong? Sometimes we tried to be opinionated rather than leaving the reader to make up their own mind. Finally, it looks like you or your editor are removing a bunch of newlines, making diffs much larger, so if you can avoid that it's easier to review. Thanks!

@strixy strixy closed this Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants