This repository was archived by the owner on May 24, 2023. It is now read-only.
Added a link to the official list of drivers#93
Closed
strixy wants to merge 1 commit intoVividCortex:gh-pagesfrom
strixy:patch-1
Closed
Added a link to the official list of drivers#93strixy wants to merge 1 commit intoVividCortex:gh-pagesfrom strixy:patch-1
strixy wants to merge 1 commit intoVividCortex:gh-pagesfrom
strixy:patch-1
Conversation
I thought it would be helpful to add a link to a list of other drivers that are available. I thought it best to link to the official list, but feel free to suggest a different / better source. I also edited out a couple comma splices and attempted to use less opinionated language while maintaining the same emphasis on the best practices described.
Contributor
|
Hi, and thanks for the contribution. I'd be happy to accept the added link, but the PR is doing three things at once so it's difficult to manage. The comma editing is not grammatically correct. Those aren't comma splices. Re: tone and phrasing suggestions, if you feel it's too opinionated, can you point to what's wrong? Sometimes we tried to be opinionated rather than leaving the reader to make up their own mind. Finally, it looks like you or your editor are removing a bunch of newlines, making diffs much larger, so if you can avoid that it's easier to review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it would be helpful to add a link to a list of other drivers that are available. I thought it best to link to the official list, but feel free to suggest a different / better source. I also edited out a couple comma splices and attempted to use less opinionated language while maintaining the same emphasis on the best practices described.