Timeago component refactor

[mortigen]

I noticed that Timeago component had several issues, so I decided to update it because we use it in several places among different projects.

Changes:

• fixed handling datetime prop - it nows correctly handle Date object and string representing a date
• fix datetime attribute for <time /> tag to use toLocaleString()
• use title attribute for <time />
• allow for custom renders, for example when translations are needed:
  • renderNow - takes no arguments
  • renderMinutes - takes minutes param as number
  • renderHours - takes hours param as number
  • renderDays - takes days param as number
  • renderDate - takes date param as string (localDateString)

[kasperekt]

Should this string (the default ones) be translated maybe? Just a guess.

[mortigen]

I think react-common doesn't handle translations. That's why I thought we need those custom renders to provide translations in specific apps. With this, we can create a wrapper for Timeago for example in Feeds which will handle translations there.

[kasperekt]

Some components of design-system handles i18n, so I think it wouldn't be an issue to handle this in react-common as well. I see that we don't have any components in this repo that translates anything but maybe we should think about that.

[kasperekt]

Shouldn't this be translated?

[mortigen]

#182 (comment)

[vforge]

I like that idea. Good customization

[vforge]

Can render* function return JSX/JS string? Ideally Id like to use renderNow={() => <strong>NOW!</string>}

[mortigen]

You can return anything because it will just call your render* function and return its result. Check this fragment out: return typeof (renderNow) === 'function' ? renderNow() : 'now'; So sure, you can use it like you did it above :)