Restore old optional column width override setting #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This emulates the old nullable override setting by adding a checkbox that controls whether the setting is enabled or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #68 by emulating the old nullable override setting by adding a checkbox that controls whether the setting is enabled or not. Basically I half-implemented the suggestion from #68 (comment).
Forgive me if the impl is a bit rough. This is my first ever time touching Kotlin or IntelliJ plugins, and my first time in ~10 years touching Java or Swing, so I might be a bit rusty! I did my best to maintain the same look & feel of the existing form, had to fiddle with alignment a bit.
I don't know how best to disable the column override text field when the checkbox is not selected. If you want to give some direction on how you'd like to see it implemented I'd be happy to take a stab at it, otherwise I'll leave it to you.
I threw this together for my own use, figured I'd put up a PR in case you want to take this direction instead of trying to get nullable values working again.