Skip to content

remove undefined 'clean_token' and 'clean_lemma', adding missing 'import sys' #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lizaku merged 4 commits into from
Oct 1, 2020
Merged

remove undefined 'clean_token' and 'clean_lemma', adding missing 'import sys' #51

lizaku merged 4 commits into from
Oct 1, 2020

Conversation

@DanilSko
Copy link
Contributor

@DanilSko DanilSko commented Sep 27, 2020

  1. 'clean_token' and 'clean_lemma' functions in the process function are not defined in the notebook.
  2. tag_ud requires sys yet sys is not imported

@akutuzov akutuzov requested a review from lizaku September 27, 2020 10:38
@akutuzov akutuzov added the bug label Sep 27, 2020
@lizaku
Copy link
Collaborator

lizaku commented Oct 1, 2020

Thanks for finding some mistakes in the notebook. Indeed sys was missing; as for the missing functions, I added them.

@lizaku lizaku merged commit 7fff341 into akutuzov:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lizaku lizaku lizaku approved these changes

Assignees

@lizaku lizaku

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanilSko @lizaku @akutuzov