Open
Conversation
Collaborator
|
|
Author
|
建议文档上强调一下，吃了没用单例的亏在 2024年9月22日，19:19，DQYuan ***@***.***> 写道：
ExpressRunner 建议使用单例，如果不采用单例的话，不止这一处，QLPattern 的语法解析树每次也要重新初始化
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
对
ExpressRunner进行初始化时，如果没有使用单例，有可能会导致成员变量expressInstructionSetCache每次都不会命中，每次都需要进行重新生成指令集，效率很低。ExpressRunner expressRunner = new ExpressRunner();将指令集缓存设置成静态变量可以解决这个问题。