Skip to content

docs: update JSDoc return tag to @return in registry.ts#33204

Merged
clydin merged 1 commit into
angular:mainfrom
clydin:fix/jsdoc-return-tag
May 14, 2026
Merged

docs: update JSDoc return tag to @return in registry.ts#33204
clydin merged 1 commit into
angular:mainfrom
clydin:fix/jsdoc-return-tag

Conversation

@clydin
Copy link
Copy Markdown
Member

@clydin clydin commented May 14, 2026

No description provided.

@clydin clydin added the target: patch This PR is targeted for the next patch release label May 14, 2026
@angular-robot angular-robot Bot added the area: docs Related to the documentation label May 14, 2026
@clydin clydin force-pushed the fix/jsdoc-return-tag branch from 3d544cb to fcd5d17 Compare May 14, 2026 13:28
@clydin clydin changed the title docs: update JSDoc return tag to @return in registry.ts docs: update JSDoc return tag to @return in registry.ts May 14, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JSDoc tag from @returns to @return for the ɵflatten method in the CoreSchemaRegistry class. A review comment correctly identifies that the documentation still incorrectly specifies an Observable return type instead of a Promise and provides a code suggestion to rectify this.

Comment thread packages/angular_devkit/core/src/json/schema/registry.ts Outdated
@clydin clydin force-pushed the fix/jsdoc-return-tag branch from fcd5d17 to 9361837 Compare May 14, 2026 13:43
@clydin clydin requested a review from alan-agius4 May 14, 2026 13:43
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 14, 2026
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 14, 2026
@clydin clydin merged commit c150c08 into angular:main May 14, 2026
36 checks passed
@clydin
Copy link
Copy Markdown
Member Author

clydin commented May 14, 2026

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants