pi should LaTeXize to \pi #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteBlackGoose
requested changes
Apr 21, 2020
Member
WhiteBlackGoose
left a comment
WhiteBlackGoose
left a comment
There was a problem hiding this comment.
Sorry, cannot approve this code. It requires some more than one more "if" on a constant
Member
Author
|
What do you mean? With this change, |
Member
|
The code should be of a higher quality :). Maybe we should add a table ot latexiseable constants and get all latex forms from there... but not like that |
Member
WhiteBlackGoose
left a comment
WhiteBlackGoose
left a comment
There was a problem hiding this comment.
No, you shouldn't add such "if-s" to this function. Thank you for this mistake (that constants don't have a latex form), but I probably will fix it myself.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.