Skip to content

Conversation

@shanshanzhu
Copy link

@shanshanzhu shanshanzhu commented Aug 20, 2020

Reasoning:
DYNAMIC_STREAM_METADATA configuration should be decoupled from streamSettings.

Current behavior:
when DYNAMIC_STREAM_METADATA is set to true, and streamSettings is not set, the _onXVIZTimeslice throws an error for in operator

Expected fix:
We either need to set the default value for streamSettings to {} in constructor, or do a safe check for streamSettings as in the diff.

@shanshanzhu
Copy link
Author

@twojtasz couldn't find streetscape on buildkite. Was that disabled?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants