Skip to content

feat(jwk): add a derive_key method for OKPKey#87

Merged
lepture merged 4 commits into
mainfrom
feat-okp-derive-key
Dec 12, 2025
Merged

feat(jwk): add a derive_key method for OKPKey#87
lepture merged 4 commits into
mainfrom
feat-okp-derive-key

Conversation

@lepture
Copy link
Copy Markdown
Member

@lepture lepture commented Dec 12, 2025

Feature for #82

@lepture lepture requested a review from azmeuk December 12, 2025 09:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4609690) to head (d796637).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         2875      2924   +49     
  Branches       327       335    +8     
=========================================
+ Hits          2875      2924   +49     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lepture
Copy link
Copy Markdown
Member Author

lepture commented Dec 12, 2025

@azmeuk BTW, I also add a derive_key method for ECKey.

@lepture lepture force-pushed the feat-okp-derive-key branch from d166084 to 734121d Compare December 12, 2025 12:34
Comment thread src/joserfc/_rfc7518/jwe_encs.py Fixed
raise DecodeError("tag does not match")

cipher = Cipher(AES(dkey), CBC(iv), backend=default_backend())
cipher = Cipher(AES(dkey), CBC(iv))

Check failure

Code scanning / SonarCloud

Encryption algorithms should be used with secure mode and padding scheme

<!--SONAR_ISSUE_KEY:AZsSk8LkTl4z2CG7FkvP-->Use secure mode and padding scheme. <p>See more on <a href="https://sonarcloud.io/project/issues?id=authlib_joserfc&issues=AZsSk8LkTl4z2CG7FkvP&open=AZsSk8LkTl4z2CG7FkvP&branch=feat-okp-derive-key">SonarQube Cloud</a></p>
Comment thread src/joserfc/_rfc7518/jwe_encs.py Fixed
raise DecodeError("tag does not match")

cipher = Cipher(AES(dkey), CBC(iv), backend=default_backend())
cipher = Cipher(AES(dkey), CBC(iv))

Check failure

Code scanning / SonarCloud

Encryption algorithms should be used with secure mode and padding scheme

<!--SONAR_ISSUE_KEY:AZsSk-njqlns3vvP6eng-->Use secure mode and padding scheme. <p>See more on <a href="https://sonarcloud.io/project/issues?id=authlib_joserfc&issues=AZsSk-njqlns3vvP6eng&open=AZsSk-njqlns3vvP6eng&pullRequest=87">SonarQube Cloud</a></p>
Copy link
Copy Markdown
Member

@azmeuk azmeuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test the code but just reading it.
LGTM so far. This appears very handy 🙏

@authlib authlib deleted a comment from sonarqubecloud Bot Dec 12, 2025
@authlib authlib deleted a comment from sonarqubecloud Bot Dec 12, 2025
@sonarqubecloud
Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 12, 2025

@lepture lepture merged commit d796637 into main Dec 12, 2025
25 checks passed
@azmeuk azmeuk deleted the feat-okp-derive-key branch December 12, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants