Add Helmet data module for HELMET benchmark datasets#48
Open
Jantory wants to merge 5 commits intoawslabs:mainfrom
Open
Add Helmet data module for HELMET benchmark datasets#48Jantory wants to merge 5 commits intoawslabs:mainfrom
Jantory wants to merge 5 commits intoawslabs:mainfrom
Conversation
mseeger
requested changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LongBenchV2 was the only supported dataset for long-context fine-tuning. This PR adds a Helmet data module (keys_values/data/helmet.py) that loads any HELMET benchmark dataset via the existing load_helmet_dev_eval function, enabling fine-tuning on a broader set of long-context tasks (RAG, summarization, ICL, synthetic retrieval, etc.).
What changed:
Helmet can be passed via the existing --data CLI argument using jsonargparse's class/init-args syntax, requiring no changes to the training entry point.
A use case for specifying the Helmet dataset and max sequence length can be
python keys_values/__main__.py finetune_long_lora \ "${CHECKPOINT_DIR}" \ --out_dir "${OUT_DIR}" \ --devices 2 \ --data Helmet --data.dataset_key json_kv --data.max_length 64k \ --data.max_seq_length 32768 --data.metadata_dir "${METADATA_DIR}" \ --head_model next_token_prediction \ --precision bf16-true --verbose some \ --kv_cache.name h2o-default --kv_cache.cache_length 16384 --kv_cache.chunk_size 1024 \ --train.save_interval 10 --train.micro_batch_size 4 --train.global_batch_size 8 \ --eval.interval 10By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.